Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowCovering: Zap definition updates / fixes #19968

Merged
merged 24 commits into from
Jul 4, 2022
Merged

WindowCovering: Zap definition updates / fixes #19968

merged 24 commits into from
Jul 4, 2022

Conversation

jmeg-sfy
Copy link
Contributor

@jmeg-sfy jmeg-sfy commented Jun 24, 2022 •
edited
Loading

Problem

What is being fixed? Examples:

Change overview

What's in this PR

  • Add missing global attributes on WindowCovering Endpoints (window app + all-cluster-minimal)

  • Fix GeneralCommissioning (ep 0) on window-app

  • Update Identify Clusters (ep1 2) on window-app

  • Update Groups Clusters (ep1 2) on window-app

  • Update Scenes Clusters (ep1 2) on window-app

  • Update Descriptor Clusters (ep0 1 2) on window-app

  • Remove useless Junk definition from BaseRootDevice type from (ep 1 2) (Basic Cluster, Thread, Network)

Testing

How was this tested? (at least one bullet point required)

  • Test on EFR32 + passing CI

jmeg-sfy added 22 commits July 4, 2022 11:41
@jmeg-sfy
ZAP: Window Covering clusters add missing global attributes
8b40e45
@jmeg-sfy
ZAP: Update WindowCovering for all-clusters-minimal-app
ad148cd
@jmeg-sfy
ZAP: window-app WindowCovering remove non-use declaration
7d8482c
@jmeg-sfy
ZAP: update all-clusters-minimal-app.matter
74903cb
@jmeg-sfy
ZAP: Identify ep0 add missing attribute
56725c0
@jmeg-sfy
ZAP: Identify ep2
fbaf495
@jmeg-sfy
ZAP: Identify ep1
723478c
@jmeg-sfy
ZAP: Align GeneralCommissioning
5a091d6
@jmeg-sfy
ZAP: tweak identify
3c0c1cf
@jmeg-sfy
ZAP: Add Binding Clusters on ep 1, 2
7b5fb27
@jmeg-sfy
ZAP: Scenes + Group fix ep 1,2
cbe2083
@jmeg-sfy
ZAP: Remove not used Thread Diag Cluster from Ep
4c63f44
@jmeg-sfy
ZAP: Remove not used Network Commissioning from bad ep
8011360
@jmeg-sfy
ZAP: Remove not used BASIC_CLUSTER from bad ep
5e17ea4
@jmeg-sfy
ZAP: Remove not use BASIC_CLUSTER from bad ep 2
6f79629
@jmeg-sfy
ZAP: Autogenerated files
f925e42
@jmeg-sfy
ZAP: Scenes remove non-implemented enhanced calls
f73aed9
@jmeg-sfy
ZAP: Desactivate non required Binding server cluster ep 1 2
c31c4d5
@jmeg-sfy
Revert "ZAP: Update WindowCovering for all-clusters-minimal-app"
522cbb6 
This reverts commit 985b719.
@jmeg-sfy
ZAP: all-cluster-minimal add missing global attributes
b82c9d0
@jmeg-sfy
ZAP: RollBack all-cluster-minimal.matter
b81a1d4
@jmeg-sfy
ZAP: remove Binding server artifact
ae08157
@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/window-covering-fix-zap branch from a768453 to 461b1b1 Compare July 4, 2022 10:16
@restyled-io restyled-io bot mentioned this pull request Jul 4, 2022
Closed
@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/window-covering-fix-zap branch from 461b1b1 to 289d535 Compare July 4, 2022 10:19
@github-actions
Copy link

github-actions bot commented Jul 4, 2022 •
edited
Loading

PR #19968: Size comparison from 08cb351 to 289d535

Increases above 0.2%:

platform target config section 08cb351 289d535b change % change
efr32 window-app BRD4161A (read/write) 1065500 1074052 8552 0.8
.bss 133076 134468 1392 1.0
.text 930324 937484 7160 0.8
Increases (4 builds for cc13x2_26x2, cyw30739, efr32, telink)
platform target config section 08cb351 289d535b change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 631331 631339 8 0.0
.text 553668 553676 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578798 578806 8 0.0
.app_xip_area 457576 457584 8 0.0
efr32 window-app BRD4161A (read/write) 1065500 1074052 8552 0.8
.bss 133076 134468 1392 1.0
.text 930324 937484 7160 0.8
telink light-switch-app tlsr9518adk80d text 564980 564984 4 0.0
Decreases (2 builds for esp32, nrfconnect)
platform target config section 08cb351 289d535b change % change
esp32 all-clusters-app c3devkit (read only) 1018712 1018710 -2 -0.0
.flash.text 1018712 1018710 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154095 1154079 -16 -0.0
text 799780 799776 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 08cb351 289d535b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665339 665339 0 0.0
(read/write) 185884 185884 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88099 88099 0 0.0
.text 576924 576924 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631331 631339 8 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77339 77339 0 0.0
.text 553668 553676 8 0.0
lock-ftd LP_CC2652R7 (read only) 667999 667999 0 0.0
(read/write) 173368 173368 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591328 591328 0 0.0
lock-mtd LP_CC2652R7 (read only) 617423 617423 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540864 540864 0 0.0
pump-app LP_CC2652R7 (read only) 677359 677359 0 0.0
(read/write) 164856 164856 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88439 88439 0 0.0
.text 588436 588436 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663183 663183 0 0.0
(read/write) 179152 179152 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578424 578424 0 0.0
shell LP_CC2652R7 (read only) 657790 657790 0 0.0
(read/write) 188936 188936 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572628 572628 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578798 578806 8 0.0
.app_xip_area 457576 457584 8 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580454 580454 0 0.0
.app_xip_area 459040 459040 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581878 581878 0 0.0
.app_xip_area 461504 461504 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080252 1080252 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945188 945188 0 0.0
BRD4161A+rpc (read/write) 1134596 1134596 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982640 982640 0 0.0
BRD4161A+rs911x (read/write) 946340 946340 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803504 803504 0 0.0
lock-app BRD4161A+wf200 (read/write) 1126984 1126984 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980716 980716 0 0.0
window-app BRD4161A (read/write) 1065500 1074052 8552 0.8
.bss 133076 134468 1392 1.0
.data 2076 2076 0 0.0
.text 930324 937484 7160 0.8
esp32 all-clusters-app c3devkit (read only) 1018712 1018710 -2 -0.0
(read/write) 1484906 1484906 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214792 214792 0 0.0
.flash.text 1018712 1018710 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072747 1072747 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067363 1067363 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658096 658096 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580788 580788 0 0.0
lock k32w061+release (read/write) 684676 684676 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606892 606892 0 0.0
linux all-clusters-app debug (read only) 2955281 2955281 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263229 263229 0 0.0
.text 2514866 2514866 0 0.0
all-clusters-minimal-app debug (read only) 2809409 2809409 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264925 264925 0 0.0
.text 2369474 2369474 0 0.0
bridge-app debug+rpc (read only) 2312329 2312329 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1952642 1952642 0 0.0
chip-tool debug (read only) 10196725 10196725 0 0.0
(read/write) 611816 611816 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 580032 580032 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 507493 507493 0 0.0
.text 8278197 8278197 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9923396 9923396 0 0.0
(read/write) 676609 676609 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615592 615592 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470260 470260 0 0.0
.text 7911236 7911236 0 0.0
lighting-app debug+rpc (read only) 2548105 2548105 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2164498 2164498 0 0.0
lock-app debug (read only) 2510497 2510497 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228328 228328 0 0.0
.text 2117026 2117026 0 0.0
ota-provider-app debug (read only) 2319153 2319153 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1952962 1952962 0 0.0
ota-requestor-app debug (read only) 2436353 2436353 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207424 207424 0 0.0
.text 2057778 2057778 0 0.0
shell debug (read only) 2544897 2544897 0 0.0
(read/write) 141064 141064 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227346 227346 0 0.0
.text 2161186 2161186 0 0.0
thermostat-no-ble arm64 (read only) 2591892 2591892 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2186768 2186768 0 0.0
tv-app debug (read only) 3099249 3099249 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2662130 2662130 0 0.0
tv-casting-app debug (read only) 5560057 5560057 0 0.0
(read/write) 161712 161712 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102824 102824 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343433 343433 0 0.0
.text 4939698 4939698 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447312 2447312 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409956 1409956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173243 1173243 0 0.0
bss 142900 142900 0 0.0
rodata 141356 141356 0 0.0
text 810088 810088 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154095 1154079 -16 -0.0
bss 142136 142136 0 0.0
rodata 133288 133288 0 0.0
text 799780 799776 -4 -0.0
p6 all-clusters-app default (read/write) 2562896 2562896 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521160 1521160 0 0.0
all-clusters-minimal-app default (read/write) 2508760 2508760 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467024 1467024 0 0.0
light-app default (read/write) 2439128 2439128 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397392 1397392 0 0.0
lock-app default (read/write) 2465560 2465560 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423824 1423824 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796480 796480 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 564980 564984 4 0.0
lighting-app tlsr9518adk80d (read/write) 816316 816316 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581306 581306 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit 8fbfe6a into project-chip:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
4 participants
@jmeg-sfy @bzbarsky-apple @woody-apple @jmartinez-silabs